Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FileUploader, CodeSnippet): backport a11y fixes to v10 #14091

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix(FileUploader, CodeSnippet): backport a11y fixes to v10 #14091

merged 3 commits into from
Jul 6, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #13870
Closes #12498
Refs #12105
Refs #13310

Backports a few a11y fixes for CodeSnippet and FileUploader

Changelog

Changed

  • Copied changes over from v11 regarding the referenced issues.
  • Changes FileUploaderDropContainer to a button, improves screen reader support
  • adds tab stop to multi-line CodeSnippet

Testing / Reviewing

Ensure there are no regressions in functionality / styles in FileUploader and multi-line CodeSnippet, and that there are no a11y violations

@tw15egan tw15egan requested a review from a team as a code owner June 26, 2023 17:03
@tw15egan tw15egan requested review from alisonjoseph and guidari and removed request for a team June 26, 2023 17:03
@tw15egan tw15egan added version: 10 Issues pertaining to Carbon v10 status: ready for review 👀 labels Jun 26, 2023
@tw15egan tw15egan changed the title fix(FileUploader, CodeSnippet): backport a11y fixes fix(FileUploader, CodeSnippet): backport a11y fixes to v10 Jun 26, 2023
@netlify
Copy link

netlify bot commented Jun 26, 2023 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit cb35f8e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6499caa4f8e01b0008ddd58a
😎 Deploy Preview https://deploy-preview-14091--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan tw15egan requested a review from a team as a code owner June 26, 2023 17:28
guidari
guidari approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍
No violations anymore and the components are working fine

@tay1orjones tay1orjones linked an issue Jun 29, 2023 that may be closed by this pull request
[a11y]: port a11y fixes to v10 #13870
Closed
2 tasks
@kodiakhq kodiakhq bot merged commit 576add8 into v10 Jul 6, 2023
@kodiakhq kodiakhq bot deleted the a11y-fix-backport branch July 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉 version: 10 Issues pertaining to Carbon v10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[a11y]: port a11y fixes to v10
4 participants
@tw15egan @alisonjoseph @guidari @tay1orjones